godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
88.81k stars 20.14k forks source link

Changing language in the project manager doesn't work on Android #60353

Open Calinou opened 2 years ago

Calinou commented 2 years ago

Godot version

4.0.alpha6, 3.5.beta4

System information

OnePlus 6, Android 11 and Samsung Galaxy Fold2, Android 12

Issue description

This was first reported in https://github.com/godotengine/godot/issues/60344, but I can confirm it on two separate devices on both 3.5beta4 and 4.0alpha6.

This is likely caused by OS.set_restart_on_exit() not being implemented on Android, along with configuration file saving routines not being called in time before Android ends the activity.

As a workaround, we could hide the language selection dropdown in the project manager, but it'd be better to implement the required functionality to make it work. Or, even better, we can implement switching languages without having to restart the project manager or editor.

In the meantime, switching the language after creating a project in the Editor Settings should work, as long as you manually exit the editor instead of using the Save and Restart button (which has the same problem).

Steps to reproduce

Minimal reproduction project

N/A

akien-mga commented 2 years ago

See https://github.com/godotengine/godot/pull/61211/files/9e64f3de6cdcaea43835643070810a2b175abe4c#diff-14e22e9144f620db2f6d4526b2d95442f0777303ad10b5c1690c328a100c728a, the language selection dialog has been hidden to work around this issue, but this should be fixed properly and made visible again eventually.

Alex2782 commented 1 month ago

See https://github.com/godotengine/godot/pull/61211/files/9e64f3de6cdcaea43835643070810a2b175abe4c#diff-14e22e9144f620db2f6d4526b2d95442f0777303ad10b5c1690c328a100c728a, the language selection dialog has been hidden to work around this issue, but this should be fixed properly and made visible again eventually.

= Merged, Could the language selection list be displayed again? Not so important for me, perhaps a good task for label: “good first issue”

2 screenshots (V4.3 / V4.2.2) ------------------------------------- **Godot 4.3** on Android ![image](https://github.com/user-attachments/assets/3fe2f5f8-93ef-4c54-96dc-553f4146968f) **Godot 4.2.2** on Windows (foreground) vs. on Android (background) ![Screenshot 2024-07-24 230935](https://github.com/user-attachments/assets/d48ab2fe-c8de-4181-a7ad-a5eac9637e62)
akien-mga commented 1 month ago

= Merged, Could the language selection list be displayed again?

That PR that was merged is the one that his the language selection dropdown, as a workaround for this bug. It was a while ago but I don't see a reference that the actual feature of the language selection was fixed for Android (this bug).