[GodotPhysics] Angular/Linear Spring options don't work in Generic6DOFJoint3D

godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine

https://godotengine.org

MIT License

89.56k stars 20.6k forks source link

[GodotPhysics] Angular/Linear Spring options don't work in Generic6DOFJoint3D #61637

Open Leakbang opened 2 years ago

Leakbang commented 2 years ago

Godot version

v4.0.alpha.calinou [c89d2b8aa]

System information

Archlinux

Issue description

The Angular Spring and Linear Spring options do not work in Generic6DOFJoint3D. I have messed around with the settings and I don't see the joint working in any shape or form.

Steps to reproduce

Add Generic6DOFJoint3D
Disable linear and angular limits
Enable Linear/Angular springs
Connect 2 nodes to the joint

Minimal reproduction project

spring-joints.tar.gz wasd to control the red ball

Calinou commented 2 years ago

Can you reproduce this in 3.4.4/3.5rc2 when using GodotPhysics as the 3D physics engine?

Leakbang commented 2 years ago

I just did a test and I can verify that this is also present in 3.4.4 only when using GodotPhysics. However it works as intended with Bullet physics.

Leakbang commented 2 years ago

After taking a quick look at it, the code segments are absolutely empty. They were never implemented in the first place

https://github.com/godotengine/godot/blob/1baee2189c21ae36c852ddff10f769b1134509ca/servers/physics_3d/joints/godot_generic_6dof_joint_3d.cpp#L599