Movie writer doesn't use correct aspect ratio with window override and stretch settings

[joemicmc]

Godot version

4.0 beta 10

System information

Windows 10, Vulkan, AMD RX 5600 XT

Issue description

When you set a combination of settings in project settings > general > display > window, the output avi file does not have the correct aspect ratio

Size

• Viewport Width: 640
• Viewport Height: 360
• Window Width Override: 1280
• Window Height Override Override: 720

Stretch

• Mode: viewport
• Aspect: keep_width

Steps to reproduce

• Open the attached project.
• Enable movie writer
• Run the project
• Check the aspect ratio of the captured avi file

Minimal reproduction project

movie-writer-aspect-ratio.zip

[joemicmc]

Current workaround is to not use the window override and then scale the avi using extra ffmpeg arguments (use it already to convert to mp4). Nearest neighbour is to try and preserve the crisp pixels.

ffmpeg -i input.avi -s WIDTHxHEIGHT -sws_flags neighbor output.mp4

[Calinou]

This is strange, because only the viewport dimensions should matter when using the viewport stretch mode in Movie Maker mode. The actual window size set with the override should not affect the dimensions of the output video, even if you resize it while recording. This is why I was originally able to document https://github.com/godotengine/godot-docs/pull/6398.

That said, even if this is fixed, the video will still not be scaled for you – you'll have to do this in post-process, or use a custom viewport instead of relying on the root viewport's scaling.

[joemicmc]

Hehe, I just updated my script to convert avi to mp4 to do the scaling! So have a workaround.

Also, used the cool project settings overrides to set the window overrides in movie mode to be 0 so I don't have to keep changing settings. Such a neat feature.

[Ayush-singla27]

if i understood this correctly, the main issue is that output avi file should not scale with actual window size. Right?

[Calinou]

if i understood this correctly, the main issue is that output avi file should not scale with actual window size. Right?

It should when using the disabled or 2d stretch modes, but not when using the viewport stretch mode.

[skeddles]

I ran into this too, still happening in 4.2.2

setting stretch mode to disabled and resetting window_width_override/window_height_override to 0 is sort of a workaround, if you want to render at 1x

though I found it better to change stretch mode to canvas_items, then you can keep the width/height override and render at a higher resolution, which is what I was hoping for / expecting. i would still have expected it to render scaled up with the viewport mode set to stretch.

imo rendering at 1x and then scaling up with nearest neighbor is a bad idea because the frames are getting jpeggified (even if mjpeg quality is set to 1 apparently), and you're going to end up scaling up that jpeggification making it much more noticeable.

[Calinou]

imo rendering at 1x and then scaling up with nearest neighbor is a bad idea because the frames are getting jpeggified (even if mjpeg quality is set to 1 apparently), and you're going to end up scaling up that jpeggification making it much more noticeable.

For pixel art, you should use PNG output (or QOI if https://github.com/godotengine/godot/pull/91263 is merged). JPEG is still a lossy format at 100% quality.

[skeddles]

My target destination is still video, even with rendering it to PNG, it would still end up getting JPEGged at the end when converted to MP4 - I'm just suggesting people avoid scaling up JPEG/JPEGged video because it will scale up the artifacts and make them more noticeable.

Though it's true, rendering to PNG could be a better workaround for now, if you want to force everything to be rendered at the native resolution, since changing to the canvas_items stretch mode renders everything at higher res.

But I hope this can be fixed so that when using the viewport stretch mode you can render scaled up pixel art video at the native resolution.