search

godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
90.36k stars 21.06k forks source link

Backport 4.0 GodotPhysics fixes for 3.6 #71961

Open elvisish opened 1 year ago

elvisish commented 1 year ago

Godot version

4.0 beta 14

System information

Windows 10

Issue description

Recent updates to 4.0 such as https://github.com/godotengine/godot/pull/71447 and https://github.com/godotengine/godot/pull/70660 would be beneficial to projects close to completion in 3.x, but not using Bullet Physics (Gridmaps, for instance, have collision issues in 3.5 when using bullet that doesn't happen with GodotPhysics). I'm reopening this here as I previously incorrectly opened it as a proposal: https://github.com/godotengine/godot-proposals/issues/6158

Steps to reproduce

Most of the bugs are listed here: https://github.com/godotengine/godot/issues/45333#issuecomment-1361786077

Minimal reproduction project

N/A

Calinou commented 1 year ago

cc @peastman @Malcolmnixon

Note that it may be better to wait a little until physics work stabilizes in 4.0, so we can backport completed work once rather than having to backport fixes several times.

elvisish commented 1 year ago

cc @peastman @Malcolmnixon

Note that it may be better to wait a little until physics work stabilizes in 4.0, so we can backport completed work once rather than having to backport fixes several times.

I absolutely agree, while I'd love the fixes now, I think it would be best to plan for 3.6 having solid physics that can support games being finished with 3.x.

elvisish commented 1 year ago

cc @peastman @Malcolmnixon

Note that it may be better to wait a little until physics work stabilizes in 4.0, so we can backport completed work once rather than having to backport fixes several times.

Have there been enough improvements in 4.0 and 4.1 to warrant a backport to 3.6 yet? 4.2 is just around the corner and physics seem a lot more solid than they were in 3.5.

AThousandShips commented 1 year ago

4.2 is just around the corner

4.2? 4.1 hasn't even been released, it's not even in feature freeze yet

elvisish commented 1 year ago

4.2 is just around the corner

4.2? 4.1 hasn't even been released, it's not even in feature freeze yet

I honestly don't know why I thought it had been already, I think I was getting confused with 4.1 being around the corner (still interested if it'll be backported now as 4.0 is nearly done with).

Saul2022 commented 1 year ago

.

Have there been enough improvements in 4.0 and 4.1 to warrant a backport to 3.6 yet? 4.2 is just around the corner and physics seem a lot more solid than they were in 3.5.

While it true i think it could be better to wait more, as i think that there could be more fixes incoming when w4 hires the physics engineer they plan, so then they can merge the 4.x changes without doing it more often.