godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
91.1k stars 21.18k forks source link

.ogg sample support #7325

Closed Duskitten closed 7 years ago

Duskitten commented 7 years ago

So the game im working on i have most of the sounds as .ogg files, and they arent too too long, but i'd like to keep the smaller file size when using them, would it be possible to add support in sample players for .ogg files?

bojidar-bg commented 7 years ago

If they are going to be converted to .smp anyway, why bother? The idea behind using .wav is that wavs are not lossily compressed, and therefore have no artefacts in them.

reduz commented 7 years ago

Godot uses IMA-ADPCM compression for sound effects, using .ogg files in sample players means a very inefficient use of CPU. Best you can do is to either use .wav files, or import the audio as .smp

On Sun, Dec 18, 2016 at 2:37 PM, Bojidar Marinov notifications@github.com wrote:

If they are going to be converted to .smp anyway, why bother? The idea behind using .wav is that wavs are not lossily compressed, and therefore have no artefacts in them.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/godotengine/godot/issues/7325#issuecomment-267834723, or mute the thread https://github.com/notifications/unsubscribe-auth/AF-Z25jbNNQ8xAjOTYtqImg-8NKxtGIDks5rJW9CgaJpZM4LQGkg .

freemanfromgodotengine commented 7 years ago

@Duskitty I would convert sounds to mono, 16-bit, 44100 Hz sample resolution wav files (if they are sound effects and your game is a 2d game). And if you really need more space, I would even go with 22050 Hz sample rate. With music I would stay with ogg format and use the streamplayer.

akien-mga commented 7 years ago

As per the above I guess this is a wontfix.

Calinou commented 2 years ago

In case someone lands on this page from a web search, Godot 3.0 and later supports using Ogg Vorbis samples anywhere (regardless of length or purpose): https://docs.godotengine.org/en/latest/tutorials/assets_pipeline/importing_audio_samples.html#doc-importing-audio-samples

MP3 is also supported since Godot 3.3.