godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
91.2k stars 21.21k forks source link

Zoom Reset overrides code font size in Editor Settings. #75295

Open BrunoDSL opened 1 year ago

BrunoDSL commented 1 year ago

Godot version

v4.0.1.stable.mono.official [cacf49999]

System information

Windows 10 x64, 8GB RAM, Radeon RX550 4 GB

Issue description

It seems some of the setting values (if not all of them) are hard coded to a specific value rather than be what the user sets. If I set the code font size to a different value, then accidentally change the zoom value with a keyboard shortcut, resetting the zoom using Ctrl+0 changes the font size to the default value instead of the value I have configured in the settings. Once that happens, going to editor settings and changing the code font value to something else does nothing, only changing to the value I placed once Godot is reset.

Steps to reproduce

1 - Change the Code Font size to a different value. 2 - In the script editor, change the zoom using a keyboard shortcut 3 - Reset the zoom to the default using the keyboard shortcut.

Minimal reproduction project

N/A

AThousandShips commented 1 year ago

This is by design, zooming in the editor changes the setting, that's how it's kept

BrunoDSL commented 1 year ago

This is by design, zooming in the editor changes the setting, that's how it's kept

The issue here is the default value is not the one I have set in editor settings, but a magic number that's hard coded. If I need to zoom in or out momentarily, I cannot go back to the value I have set really via shortcut unless I either reset the engine or change said value back in settings, which is cumbersome, unintuitive and defeats the purpose of having settings you can change.

AThousandShips commented 1 year ago

That would require a second saved value somewhere, but can be done, but to be clear the value you set in the settings isn't a default value, it's the font size, as it's name says

Calinou commented 1 year ago

There's been discussion about not persisting code font zoom anymore to editor settings (as saving editor settings is slow).

Instead, adjusting code font zoom should multiply the value set in the editor settings, and this multiplier won't be saved anywhere.