aganm
commented
2 months ago I have to add that there is more wrong with the color themes in Godot 4 than meets the eye. Both Solarized themes have regressed. Dark have regressed a little, but light looks downright wrong. Let me show you:
Solarized Dark:
Solarized Light:
How say, the Solarized themes in Godot 3, both dark and light, were perfect. And in Godot 4, they were changed away from perfect, and so they look wrong now. Despite my contrast PR and this newer PR to fix the missing minimap highlights, the colors are still wrong. There needs to be a complete revert of the solarized themes in Godot 4 to what they were in Godot 3.
It's kind of subtle but it's also evident to my Solarized used eyes that Godot 4 solarized themes are way off. It's made very very evident when I have my code editor (which uses a correct solarized theme), side by side with Godot 3, where Godot 3 matches perfectly. I can use the pipette and compare the matching colors between my editor and Godot 3, and the colors match perfectly. Godot 4 is all wrong, lights are too bright, or too dark, and darks are too bright, or too dark, tones are off as well.
Godot version
4.0+
System information
Godot v4.0+
Issue description
The light themes in godot 4 have regressed from godot 3. I expect the theme 'Solarized Light' in godot 4 to look exactly the way it looked in godot 3.
Steps to reproduce
Open godot, go to the Editor -> Editor Settings -> Interface -> Theme, and change the theme to one of the light themes, either 'Light' or 'Solarized Light'.
Minimal reproduction project
Create a brand new empty project in godot and see the solarized light theme in godot 3:
Compare it to godot 4, where the colors are overblown and the minimap has no highlight:
I opened PR #78297 to attempt fixing the overblown colors (by simply reducing the negative contrast) until I realized that the minimap hightlight was also missing.