godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
90.46k stars 21.07k forks source link

Godot 4.1.1 gridmap doesn't update from meshlibrary properly when saving meshlibrary as .tres file #82726

Closed elvisish closed 11 months ago

elvisish commented 1 year ago

Godot version

4.1.1 stable

System information

Windows 10

Issue description

Updating the gridmap meshlibrary scene and updating the meshlibrary changes the scene in the editor, but doesn't reflect the changes when running the scene or re-opening it:

https://github.com/godotengine/godot/assets/16231628/94f433c8-6599-4e39-8e42-626c514b8d52

Steps to reproduce

FIX: don't save the meshlibrary as a .tres file, keep it embedded in the scene: image

Minimal reproduction project

N/A

elvisish commented 1 year ago

I wonder if the MeshLibrary resource needs to be updated when the Gridmap is updated, perhaps the changes are just not being saved back to the resource file?

KoBeWi commented 11 months ago

Can't reproduce in 4.2.

akien-mga commented 11 months ago

@elvisish Can you check if it's also fixed for you in 4.2-rc1 or later?

elvisish commented 11 months ago

@elvisish Can you check if it's also fixed for you in 4.2-rc1 or later?

̶I̶t̶'̶s̶ ̶s̶t̶i̶l̶l̶ ̶b̶r̶o̶k̶e̶n̶ ̶i̶n̶ ̶R̶C̶1̶:̶ ̶̶ ̶S̶a̶v̶e̶ ̶t̶h̶e̶ ̶M̶e̶s̶h̶L̶i̶b̶r̶a̶r̶y̶ ̶a̶s̶ ̶a̶ ̶r̶e̶s̶o̶u̶r̶c̶e̶ ̶f̶i̶l̶e̶ ̶̶ ̶C̶h̶a̶n̶g̶e̶ ̶t̶h̶e̶ ̶p̶o̶s̶i̶t̶i̶o̶n̶ ̶o̶f̶ ̶a̶ ̶m̶e̶s̶h̶ ̶a̶n̶d̶ ̶s̶a̶v̶e̶ ̶̶ ̶U̶p̶d̶a̶t̶e̶ ̶t̶h̶e̶ ̶M̶e̶s̶h̶L̶i̶b̶r̶a̶r̶y̶ ̶w̶i̶t̶h̶ ̶a̶p̶p̶l̶i̶e̶d̶ ̶t̶r̶a̶n̶s̶f̶o̶r̶m̶s̶ ̶i̶n̶ ̶t̶h̶e̶ ̶s̶c̶e̶n̶e̶ ̶̶ ̶S̶a̶v̶e̶ ̶t̶h̶e̶ ̶s̶c̶e̶n̶e̶,̶ ̶c̶l̶o̶s̶e̶ ̶a̶n̶d̶ ̶r̶e̶o̶p̶e̶n̶ ̶*̶ ̶P̶o̶s̶i̶t̶i̶o̶n̶s̶ ̶w̶i̶l̶l̶ ̶b̶e̶ ̶b̶a̶c̶k̶ ̶t̶o̶ ̶o̶r̶i̶g̶i̶n̶a̶l̶ ̶p̶o̶s̶i̶t̶i̶o̶n̶ ̶ ̶R̶e̶p̶e̶a̶t̶i̶n̶g̶ ̶t̶h̶e̶ ̶s̶t̶e̶p̶s̶ ̶a̶b̶o̶v̶e̶ ̶w̶i̶t̶h̶ ̶t̶h̶e̶ ̶M̶e̶s̶h̶L̶i̶b̶r̶a̶r̶y̶ ̶e̶m̶b̶e̶d̶d̶e̶d̶ ̶i̶n̶t̶o̶ ̶t̶h̶e̶ ̶g̶r̶i̶d̶m̶a̶p̶ ̶w̶i̶l̶l̶ ̶w̶o̶r̶k̶.̶

It seems to be fixed, I'm not sure why it didn't stick the first time but it looks good to go now in RC1.