search

godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
91.18k stars 21.2k forks source link

Color picker does not pick up color #82925

Open RoyBeer opened 1 year ago

RoyBeer commented 1 year ago

Godot version

v4.1.1.stable.official [bd6af8e0e]

System information

Godot v4.1.1.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1660 Ti (NVIDIA; 31.0.15.3623) - Intel(R) Core(TM) i5-9400F CPU @ 2.90GHz (6 Threads)

Issue description

Picking up color with the color picker only works on surfaces that can't be selected. If it can be selected, it gets focused in the scene tree instead, closing the previous color picker dialog by loading the newly selected node's inspector information.

It seems to be connected with this issue, maybe even just a special case - reporting it just in case it is not

Steps to reproduce

Add colorful Sprite2D node Add ColorRect node Select ColorRect node Open color dialog in Inspector tab Press "Pick a color from the screen" button Hover over Sprite2D node - Notice the color picker dialog updating the value as you move the cursor Left click while cursor is over Sprite2D node

Expected behaviour: The last active values are saved inside the ColorRect node's color value and the "Pick a color from the screen" mode is disabled

Actual behaviour: The ColorRect node's color value does not update The Sprite2D node is selected, filling the Inspector tab with it's values instead

Minimal reproduction project

N/A

alexpalade commented 1 year ago

I cannot reproduce it on Arch Linux, Godot v4.1.1.stable (bd6af8e0e). I recorded a video to make sure it's the correct scenario.

RoyBeer commented 1 year ago

I cannot reproduce it on Arch Linux, Godot v4.1.1.stable (bd6af8e). I recorded a video to make sure it's the correct scenario.

That's the correct scenario, yes. However, I think I figured out what's wrong. I recorded a video as well. As you can see in the video it works as expected as long as the node which color is to be changed is visible.

https://github.com/godotengine/godot/assets/16647738/db56b74e-e319-4374-b9b3-03b44de6ffc4

I encountered the same issue in another scene, this time regardless of the visiblity.

AdilDevStuff commented 10 months ago

Happening with me as well on Godot 4.2.1 stable

https://github.com/godotengine/godot/assets/94475453/99da47ec-753c-40d8-81e8-7040b16623fa