godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
90.8k stars 21.13k forks source link

Confirmation Dialog should not be able to maximized or minimized. #85835

Closed tokengamedev closed 1 month ago

tokengamedev commented 11 months ago

Tested versions

System information

Windows 11

Issue description

When you delete a node in scene tree or delete a file from the files system. A confirmation dialog is shown. This dialog can be maximized or minimized, and even can be moved outside of the application (in windows). this needs to be removed as these are not correct features for confirmation dialog.

image

Steps to reproduce

Delete a node from the scene tree and then dialog is shown Delete a file from the file system in the editor and the dialog is shown There are other ways dialog is shown also but this feature is not required in the above two conditions.

Minimal reproduction project (MRP)

N.A

tokengamedev commented 11 months ago

Additionally the text of buttons could be Yes and No or Delete and Cancel rather than OKand Cancel, but it is enhancement and requires a proposal.

eugene87222 commented 8 months ago

Hi @akien-mga, is there any way to distinguish between this general type of confirmation dialog and some special-purpose dialogs, such as open file dialog, import project dialog, etc.? I noticed that in Godot, many dialogs inherit from AcceptDialog or ConfirmationDialog, so directly enabling FLAG_RESIZE_DISABLED in these two classes is not a good idea apparently. It might affect a lot of functionality. Currently, it seems that only the Popup class sets FLAG_RESIZE_DISABLED to true.

tokengamedev commented 1 month ago

I think it is working as designed, so closing it.