godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
90.35k stars 21.06k forks source link

GPUParticles2D - editor crash if GPUParticles2D finished signal is connected to queue_free on a one shot system #87287

Open tivec opened 9 months ago

tivec commented 9 months ago

Tested versions

v4.2.1.stable.official [b09f793f5]

System information

Godot v4.2.1.stable - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1660 Ti (NVIDIA; 31.0.15.3699) - AMD Ryzen 7 4800H with Radeon Graphics (16 Threads)

Issue description

If you connect the finished signal of a one-shot GPUParticles2D to its queue_free function and the system is the root of the scene, triggering emit on the system in the editor will cause it to crash.

Steps to reproduce

Minimal reproduction project (MRP)

MRP-ParticleCrash.zip

tivec commented 9 months ago

Related to https://github.com/godotengine/godot/issues/81320

Griiimon commented 6 months ago

This would be solved by #74796