godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
88.73k stars 20.12k forks source link

Editor does not use Godot icon on Wayland (uses default Wayland icon instead) #87747

Open Calinou opened 7 months ago

Calinou commented 7 months ago

Tested versions

System information

Godot v4.3.dev (cae759949) - Fedora Linux 39 (KDE Plasma) - Wayland - GLES3 (Compatibility) - NVIDIA GeForce RTX 4090 (nvidia; 545.29.06) - 13th Gen Intel(R) Core(TM) i9-13900K (32 Threads)

Issue description

The editor doesn't use Godot icon on Wayland; it uses the default Wayland icon instead. This is printed when the editor starts:

WARNING: Icon not supported by this display server.
     at: set_icon (servers/display_server.cpp:587)

This isn't printed when running the project directly with the --path command line argument.

See the editor icon in top-left corner (default Wayland icon), project icon in bottom-right corner:

image

Steps to reproduce

Use a Wayland session, enable the Prefer Wayland editor setting then restart the editor.

Minimal reproduction project (MRP)

N/A

Riteo commented 7 months ago

This is, somewhat surprisingly, intended behavior.

The "Wayland" way of setting an icon is to actually let the DE do it for you, by setting a proper .desktop for the window's app id.

So this is actually more of a packaging issue than a backend one.

Edit: BTW, the icon still appears when running with path as it's running with XWayland. To run projecrs with Wayland, either pass --display-driver wayland or set the relative project setting.