godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
90.75k stars 21.12k forks source link

PWA wont declare itself as installable if title is " " (Space string) #89622

Closed PeterMarques closed 7 months ago

PeterMarques commented 7 months ago

Tested versions

3.x

System information

chrome mobile

Issue description

So, now i start to get what maybe is happening.

Some of my projects display "Install App", some of my projects display "add page to homescreen"

Both works the same, but no;

All my current reports, and i will check old ones, maybe be based on add page, not install app.

The thing is, the same export on a new app works and show install app, but on the old one, published, all new versions will show add page to home screen...

What i will do now, as a way of cleansing:

i will delete everything i have instaled, will downhost the pages, and will re-create from a new project, the published one.

I will NOT install the app, neither will add to homepage.

What i will do is, slowly re-iterate the app (something that can be done instatly by just copy full projet to new one) , crucial step to crucial step, and will monitour the PWA detection.

As stated, a blank new one is being correct detected, so, by this aporuch, i shall clean any problems, and either fix by unplug-replug, or, find the root cause of not being able to.

One thing that now i do not know how to aprouch, and will do it by keeping the fix, is the https://github.com/godotengine/godot/issues/69414

On that, i found that changing navigate to follow kinda fix a crash on one of my old devices. I shall keep that fix, but: https://developer.mozilla.org/en-US/docs/Web/API/Request/mode State that the "follow" atribute is not even a valid option to event.request.mode... so kinda in the dark.

Steps to reproduce

none

Minimal reproduction project (MRP)

none

PeterMarques commented 7 months ago

And, already found a canditate.

If one has a " " as project name. (Yes, a single empty space) it does not show the PWA installer if one has "" (a null string) it shows "Godot Game" as name.

And i indeed diddlydo have a " " as project name, because i change the title via script.

So...

At least, if one has " ", it does not work.

Will patch that up on deplyed project and maybe its progress.

PeterMarques commented 7 months ago

And yes.

Now i can at least garantee that i am on the PWA ecosystem. The usage is on my option virtually indiferent from the save app/pin page to homescrenn, but maybe some stuff on the background is lacking.

Closing with the learning that there is some title strings that prevent PWA install.