godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
88.7k stars 20.12k forks source link

XRFaceTracker Missing BROW_INNER_UP Blendshape, Inconsistent Naming Convention #90567

Open InfernalWAVE opened 4 months ago

InfernalWAVE commented 4 months ago

Tested versions

System information

Godot v4.3.dev5 - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3070 (NVIDIA; 31.0.15.3699) - AMD Ryzen 5 5600X 6-Core Processor (12 Threads)

Issue description

XRFaceTracker uses the Unified Expressions blendshapes, documented here: https://docs.vrcft.io/docs/tutorial-avatars/tutorial-avatars-extras/unified-blendshapes

Several of the blendshapes are named using the OpenXR convention, which follows the Meta Quest Pro naming convention, shown in the comparison chart here: https://docs.vrcft.io/docs/tutorial-avatars/tutorial-avatars-extras/compatibility/overview

There are 2 issues in the implementation:

Steps to reproduce

N/A, engine design issue.

Minimal reproduction project (MRP)

N/A, engine design issue.

InfernalWAVE commented 4 months ago

face expression map.xlsx

adding a spreadsheet i made of the unified expression blendshapes that correspond with the BlendShapeEntry enum, and how they map to ARKit indices from the comparison, in case this is helpful to anyone

BastiaanOlij commented 4 months ago

cc @Malcolmnixon