godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
88.68k stars 20.11k forks source link

Animation Tree: State machine nodes view does not refresh on Undo/Redo creating new node (until next click) #91065

Open hsandt opened 4 months ago

hsandt commented 4 months ago

Tested versions

System information

Godot v4.2.1.stable - Ubuntu 22.04.4 LTS 22.04 - X11 - Vulkan (Mobile) - dedicated NVIDIA GeForce GTX 860M (nvidia; 535.161.07) - Intel(R) Core(TM) i7-4710HQ CPU @ 2.50GHz (8 Threads)

Issue description

The Animation Tree panel's State Machine view does not update/refresh properly when undoing or redoing an Add node action. User must click on said area to force refresh.

Peek 2024-04-23 Animation Tree panel doesnt refresh on state machine add node undo-redo.webm

Steps to reproduce

  1. Add an Animation Tree node
  2. Inspector > Tree Root > new AnimationNodeStateMachine
  3. In AnimationTree panel, start adding new nodes (if you don't have dummy animations to add, just put BlendSpace1D instead)
  4. Undo (ctrl+Z) state machine node creation => no visible change
  5. Click: view is now refreshed, with nodes removed
  6. Redo (ctrl+shift+Z) => no visible change
  7. Click: view is now refreshed, with nodes re-added

Minimal reproduction project (MRP)

N/A

AThousandShips commented 4 months ago

Please try with 4.2.2

hsandt commented 2 months ago

Confirmed bug with v4.2.2.stable.official [15073afe3]

I notice that in step 5, "Click: view is now refreshed, with nodes removed" I can also just move the mouse over the Node that is supposed to be removed and it also refreshes the view (but it was probably already like that in 4.2.1).