godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
89.29k stars 20.23k forks source link

FileSystem dock won't show any file / folders, and has performance issues when loading large folders #92335

Closed FaerDerr closed 3 months ago

FaerDerr commented 4 months ago

Tested versions

Tested in 4.2.2 stable, 4.3 beta 5, 4.3 beta 6.

System information

Godot v4.2.2.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2060 (NVIDIA; 31.0.15.5186) - AMD Ryzen 5 3600 6-Core Processor (12 Threads)

Issue description

I tried loading this sprite database : https://github.com/PMDCollab/SpriteCollab/tree/master/sprite It's around ~1Go of .png (1025 pokemons + shinies, all in pixel art), saved in 1025 folders.

Here's the exhaustive list of what I encountered while trying to import that across three versions:

image image

image

Expected behaviour :

Steps to reproduce

Minimal reproduction project (MRP)

I can't upload the project here, as it weight too much. It's an empty project with just the mentioned file above, no scripts, no editor settings, no scenes.

FaerDerr commented 4 months ago

Maybe related issues : https://github.com/godotengine/godot/issues/38668

Calinou commented 4 months ago
  • When the issue is fixed after reimporting, the filesystem dock will lag & jitter, making it hard to use

This is because the entire list of files is displayed at once in the FileSystem dock. Without manual pagination or controls suited for displaying large lists, this can't be fixed.

Jordyfel commented 4 months ago

Probably the same as https://github.com/godotengine/godot/issues/47053 (at least the part about filesystem not showing up for a long time)

FaerDerr commented 4 months ago

Probably the same as #47053 (at least the part about filesystem not showing up for a long time)

I saw this one but the topic and bug seems to be targeted at godot 3.x versions, I didn't saw any issue report for 4.x versions !

I think calinou has the right call here : I'm pretty sure most of these issues could be fixed if #9678 is implemented.

Not for the import part, but a faster FileSystem might be the way. Having an option to not show the content of certain folders while still importing their contents might be an "easy" temporary fix

akien-mga commented 3 months ago

Duplicate of #47053 (reopened as #92650 was reverted for 4.3).

FaerDerr commented 3 months ago

Thanks !