Cursor disappears in editor at the end of long lines if Code Font Size set to 15

tobydjones commented 2 months ago

Tested versions

Reproducible in v4.2.2.stable.official [15073afe3]

System information

Godot v4.2.2.stable - Windows 10.0.19045 - GLES3 (Compatibility) - AMD Radeon RX 6600 (Advanced Micro Devices, Inc.; 31.0.24033.1003) - Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz (8 Threads)

Issue description

If I set Code Font Size to 15, my cursor disappears at the end of long lines

Steps to reproduce

Use a monitor 1680x1050 (this is what I use, I do not know if this is relevant)
Open Godot
Editor > Editor Settings > Interface > Editor > Code Font Size = 15
Restart editor
Open a script
Create a line that is long enough that it results in a horizontal scroll bar (eg hold down "x")

Expected result: the cursor continues to blink after the last character typed Actual result: the cursor disappears

Note the cursor blinks as expected at the default Code Font Size of 14 and at sizes 16-19 The cursor disappears at size 15, and at sizes 20-26 (which is the highest I tested)

Minimal reproduction project (MRP)

N/A

Calinou commented 2 months ago

This is likely a rounding issue somewhere. It could also be resolved by making the minimap transparent: https://github.com/godotengine/godot-proposals/issues/7215

Download commented 2 months ago

I can confirm this issue.

A good solution might be to allow you to scroll (a bit) past the end of the line... I do think the cursor is placed behind the minimap as suggested above because it only happens for lines that are long enough to fall behind the minimap. Scrolling to the right does not help for these lines, which is why I suggest adding a few extra pixels of margin after the longest line in whatever calculation is determining the longest line for the horizontal scrolling logic, to make room for the cursor. That would solve this issue independent from the minimap.

Borges-IST-2003 commented 1 month ago

Hello, is there anyone solving this issue? I'd like to try and solve it.

Calinou commented 1 month ago

Hello, is there anyone solving this issue? I'd like to try and solve it.

To my knowledge, nobody is currently looking into this, so feel free to try to solve it 🙂

Borges-IST-2003 commented 1 month ago

Great, I'll get to it.

Borges-IST-2003 commented 1 month ago

Ok, I have solved the issue, I created a small space between the right most position of the character and the minimap. So now, the cursor is no longer hidden and it's possible to see one more character to the right, which in my opinion is benefitial for the user experience. I'll submit the PR today.

godotengine / godot