godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
88.9k stars 20.16k forks source link

GPUParticles2D and GPUParticles3D have inconsistent property order in inspector #94687

Open derkork opened 1 month ago

derkork commented 1 month ago

Tested versions

System information

Godot v4.3.beta2.mono - Windows 10.0.22631 - GLES3 (Compatibility) - NVIDIA GeForce RTX 4080 (NVIDIA; 32.0.15.5599) - AMD Ryzen 9 7950X3D 16-Core Processor (32 Threads)

Issue description

GPUParticles3D and GPUParticles2D have inconsistent order of their properties in the inspector. This makes it confusing to work with particles in 2D and 3D because in 3D you have to scroll up to change time settings when you were working on the process material while in 2D you have to scroll down.

image

It would be nicer if both particle systems had the same order of properties, e.g. GPUParticles2D could look like this:

image

Steps to reproduce

Add a GPUParticles2D and a GPUParticles3D to a scene and compare the inspectors.

Minimal reproduction project (MRP)

N/A

LeonStansfield commented 1 month ago

I have noticed a couple other inconsistencies regarding the listing of parameters in the inspector:

Some of these inconsistencies are across the cpu_partciles_2d and 3d as well:

I am drafting a PR that could be used to fix these inconsistencies.

Calinou commented 1 month ago

I have a PR for this, but it went stale: https://github.com/godotengine/godot/pull/48385

It would need to be redone from scratch at this point, given particle nodes have changed a lot since 2021. You can go ahead :slightly_smiling_face: