godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
90.81k stars 21.14k forks source link

Quitting Godot does not leave you time to confirm the save dialog #95279

Closed hakro closed 2 months ago

hakro commented 2 months ago

Tested versions

System information

Godot v4.3.rc2 - TUXEDO OS 3 22.04.4 - Wayland - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4060 Laptop GPU - 13th Gen Intel(R) Core(TM) i7-13700H (20 Threads)

Issue description

When closing Godot while having unsaved changes, a confirmation dialog to save or not show up very briefly, but does not allow you to pick a choice, and Godot closes abruptly.

output.webm

The brief dialog looks like this :

Screenshot_20240808_114521

And even if you didn't choose to save, the changes are actually saved and will be visible on the next start.

Steps to reproduce

On small projects or empty, the dialog likely does not even show up, because Godot closes so quickly. So might need a sizeable project to see it, you can use any of the public demos.

Minimal reproduction project (MRP)

Not needed. Any demo project would do

akien-mga commented 2 months ago

Just open Godot (for some reason, it shows up that there are unsaved changes right out of the bat)

I've seen that in the past but I think it's specific to the W4 demos you're testing on, as its SDK modifies project settings in a @tool script.

Even then, I can't reproduce the issue on https://gitlab.com/W4Games/demos/planet-crashers:

image

The dialog stays there until I confirm a choice.

I also tried with non-W4 demos from https://github.com/godotengine/godot-demo-projects (which don't reproduce the first point in the steps to reproduce) and I don't see the issue either.

I tested with both X11 (on Wayland, so Xwayland) and Wayland DisplayDrivers.

akien-mga commented 2 months ago

Can you assess whether it's a crash that causes this abrupt closing, or it's somehow taking a path that leads to validating one of the buttons automatically? You might be able to put some breakpoints around the relevant logic in EditorNode to assess that.

Might also be worth checking whether this is tied to a specific editor setting, by temporarily resetting your editor settings (you can rename editor_settings-4.3.tres).

hakro commented 2 months ago

You're right, this seems to be project specific, in particular, this one : https://gitlab.com/W4Games/demos/w4bomber

Even then, I can't reproduce the issue on https://gitlab.com/W4Games/demos/planet-crashers:

Yeah, tested planet-crashers and other projects now, and there was no problem with them.

Might also be worth checking whether this is tied to a specific editor setting, by temporarily resetting your editor settings (you can rename editor_settings-4.3.tres).

That did not seem to have any effect.

Can you assess whether it's a crash that causes this abrupt closing

Yeah, I'll try to debug that.

For now, I'll close this issue as it's not directly tied to the engine, but if I find a more generic way to reproduce the problem (like, by updating setting from a tool script), I'll open a new issue with a proper MRP.

Thanks