godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
89.76k stars 20.85k forks source link

Compiling editor without X11 support causes OpenXR to stop the compilation #95608

Open xana43 opened 1 month ago

xana43 commented 1 month ago

Tested versions

System information

Fedora Linux 40 (KDE Plasma) - Wayland - Vulkan (Forward+) - dedicated AMD Radeon RX 7900 XT (RADV NAVI31) () - AMD Ryzen 9 7950X 16-Core Processor (32 Threads)

Issue description

when compiling a custom editor/template, if the openXR module is enabled and X11 is disabled then an error occurs doing compilation

In file included from modules/openxr/extensions/platform/openxr_opengl_extension.cpp:31: modules/openxr/extensions/platform/openxr_opengl_extension.h:71:16: error: 'XrGraphicsBindingOpenGLXlibKHR' does not name a type; did you mean 'XrGraphicsBindingOpenGLWaylandKHR'? 71 | static XrGraphicsBindingOpenGLXlibKHR graphics_binding_gl; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | XrGraphicsBindingOpenGLWaylandKHR modules/openxr/extensions/platform/openxr_opengl_extension.cpp: In member function 'virtual void* OpenXROpenGLExtension::set_session_create_and_get_next_pointer(void*)': modules/openxr/extensions/platform/openxr_opengl_extension.cpp:184:17: error: 'graphics_binding_gl' was not declared in this scope 184 | return &graphics_binding_gl; | ^~~~~~~~~~~~~~~~~~~ In file included from ./modules/openxr/openxr_api.cpp:53, from modules/openxr/scu/scu_modules_openxr.gen.cpp:1: ./modules/openxr/extensions/platform/openxr_opengl_extension.h:71:16: error: 'XrGraphicsBindingOpenGLXlibKHR' does not name a type; did you mean 'XrGraphicsBindingOpenGLWaylandKHR'? 71 | static XrGraphicsBindingOpenGLXlibKHR graphics_binding_gl; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | XrGraphicsBindingOpenGLWaylandKHR

Steps to reproduce

disable X11 support in the scons options, enable OpenXR if disabled and try to compile

Minimal reproduction project (MRP)

N/A

akien-mga commented 1 month ago

Related to #70199 and #73504.