Cannot download export template from macOS editor

godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine

https://godotengine.org

MIT License

91.41k stars 21.26k forks source link

Cannot download export template from macOS editor #95755

Open BraveEvidence opened 3 months ago

BraveEvidence commented 3 months ago

Tested versions

Godot 4.3 stable

System information

Godot v4.3.stable - macOS 14.6.1 - Vulkan (Mobile) - integrated Apple M1 - Apple M1 (8 Threads)

Issue description

I am trying to download the android build template for Godot but get an error saying Can't connect to the mirror

Steps to reproduce

Create a Godot Project. Click Project => Install Android Build Template => Click Manage Templates => Click Download & Install

Minimal reproduction project (MRP)

https://github.com/user-attachments/assets/f4eea114-d009-4d11-98b4-1348cb844ddf

DistroRickDev commented 3 months ago

Have you tried to "Open in Web browser" to check if the template file downloads?

BraveEvidence commented 3 months ago

Cool that worked but I will keep this open for now till the other button's functionality is fixed

Edit:

I also get this error, even though I installed the file downloaded from "Open in Web browser"

BraveEvidence commented 3 months ago

ok I had to unzip the folder which I downloaded from "Open in Web browser", delete the build folder from the android folder of my Godot project and then click on install again Project => Install Android Build Template

DistroRickDev commented 3 months ago

I've tested myself under: Godot v4.3.stable - Linux (Ubuntu 22.04) - Vulkan (Forward+)

And I was able to obtain it over the Click Download & Install button, from the error it seemed like a network issue on https_download_complete: https://github.com/godotengine/godot/blob/1bd740d18d714f815486b04bf4c6154ef6c355d9/editor/export/export_template_manager.cpp#L183

As it seems to download the template the engine makes use of the editor https host and port configurations: https://github.com/godotengine/godot/blob/1bd740d18d714f815486b04bf4c6154ef6c355d9/editor/export/export_template_manager.cpp#L158 https://github.com/godotengine/godot/blob/1bd740d18d714f815486b04bf4c6154ef6c355d9/editor/export/export_template_manager.cpp#L159

Do you have any proxy specific proxy configuration in the editor?

BraveEvidence commented 3 months ago

No, did not changed anything in the editor. Just downloaded Godot 4.3 and the first thing which I did was to download the template

Alex2782 commented 3 months ago

In the last 3 weeks I also had the download problems from time to time. I had to try up to 3 times to download about 1 GB of templates. Perhaps “Resume Download” would be quite good so that the download does not have to be constantly restarted.

Calinou commented 3 months ago

Perhaps “Resume Download” would be quite good so that the download does not have to be constantly restarted.

HTTPRequest does not support range requests (which is how a download can be resumed), so that would need to be implemented first.

If this was to be implemented, I'd then make the export templates downloader automatically retry a few times if the download was aborted due to an error (only after at least one byte was downloaded).

Alex2782 commented 3 months ago

https://godotengine.org/mirrorlist/4.3.stable.json

Best available is always Github I think. @BraveEvidence Can you continue to reproduce this with GitHub and TuxFamily?

Menu -> Editor -> Export Template Manager

https://github.com/godotengine/godot/blob/e3550cb20f5d6a61befaafb7d9cbdb57b24870e4/editor/export/export_template_manager.cpp#L581-L584

myselfuser1 commented 3 months ago

@Alex2782 Yes i can reproduce it using Github & TuxFamily. Check this

honey2006 commented 2 months ago

don't download from github one, use the other one!

AThousandShips commented 2 months ago

don't download from github one, use the other one!

Why?