godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
88.9k stars 20.16k forks source link

Project manager not applying custom theme correctly #96023

Open InkPhoenix opened 3 weeks ago

InkPhoenix commented 3 weeks ago

Tested versions

Reproducible in: 4.3 dev 3 [36e943b6b] and above. - Not reproducible in 4.3 dev 2 [352434668] and below

System information

Godot v4.3.stable.mono - Windows 10.0.19043 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 750 Ti (NVIDIA; 31.0.15.3734) - AMD Ryzen 5 2600 Six-Core Processor (6 Threads)

Issue description

The project manager UI (specifically the bit where you can scroll between projects) doesn't apply custom themes properly, instead it shows the last selected built-in theme, so if i select the default theme and then my custom theme i get:

project manager theme - godot 4 3 stable - default theme

if i select the black (OLED) theme and then my custom theme i get:

project manager theme - godot 4 3 stable - black (OLED) theme

if i select the Godot 2 theme and then my custom theme i get:

project manager theme - godot 4 3 stable - Godot 2 theme


so on and so forth... As you can see this didn't happen in earlier versions like 4.2.2, where that area is consistent with the rest of the UI:

project manager theme - godot 4 2 2 stable - custom theme


This bug seems to have been introduced in 4.3 dev 3, as 4.3 dev 2 and previous versions don't show signs of having this bug

4.3 dev 3:

project manager theme - godot 4 3 dev 3 - default theme

4.3 dev 2:

project manager theme - godot 4 3 dev 2 - custom theme

Steps to reproduce

Create a custom theme, select the default theme and then the custom theme, open a new instance of Godot (thefore opening the project manager). You should now see that area in the UI display the default theme instead of the custom theme.

Minimal reproduction project (MRP)

project-manager-theme-bug.zip

InkPhoenix commented 3 weeks ago

it apparently also happens to tooltips, so it could potentially happen to other UI elements as well.

tooltip 4.3 (previous theme selected: black (OLED)): tooltip 4 3 stable

tooltip 4.2.2: tooltip 4 2 2 stable

KoBeWi commented 1 week ago

I'm confused on how to reproduce this bug. How do you change the themes? You can't select custom theme from within Project Manager and selecting custom theme in editor will make it applied correctly in the manager.