Entering Full Screen in macOS makes editor laggy and buggy

hsvfan-jan commented 2 months ago

Tested versions

4.3 stable

System information

Godot v4.3.stable - macOS 14.6.1 - Vulkan (Forward+) - integrated Apple M2 Pro - Apple M2 Pro (10 Threads)

Issue description

When using Godot in full screen mode, in many places the editor becomes slow to react. E.g. when only having a single Collision2D node, it can take 0.5-3s for the shapes in the inspector (e.g. New RectangleShape2D) to appear. Another issue I noticed is that the hints for the buttons in the top (e.g. "Use Smart Snap (Shift + ..." don't appear at all anymore, no matter how long I wait for them to appear. Both issues immediately disappear when exiting Full Screen. Since they seem related I decided to put this into one bug report, even though one behavior at least works with some delay and one doesn't at all.

Steps to reproduce

Open a new project. Click the green circle in the top left to enter Full Screen mode. Notice the issue described above. After exiting Full Screen, the issue is gone.

Minimal reproduction project (MRP)

Happens in empty new project, too.

passivestar commented 2 months ago

Godot v4.3.stable - macOS 14.5.0 - Vulkan (Forward+) - integrated Apple M1 Max - Apple M1 Max (10 Threads)

Can't reproduce in an empty project

Maybe something broke in macOS 14.6.x. You can try enabling interface/editor/single_window_mode setting as a temporary workaround

hsvfan-jan commented 2 months ago

@passivestar that solves the issues I mentioned above, thanks! Sadly, it introduces another:

Both clicking with a mouse or the trackpad (no issue when tapping it) act as if I click two times. So when I click arrow down (v) on the Shape list of CollisionShape2D it opens the list. But when I click again to close that list, it immediately opens again. Happens with any dropdown and both in and out of Full Screen mode, though.

passivestar commented 2 months ago

So when I click arrow down (v) on the Shape list of CollisionShape2D it opens the list. But when I click again to close that list, it immediately opens again

That one I can reproduce. Maybe open a separate issue for that so that it's easier for other people to find and comment on it, I don't know if that one is macOS specific

arisona commented 2 months ago

I can confirm the lag as described above on a MacBook Air M2 running 14.6.1: In an empty project, adding a Collision2D node, going to full screen, then e.g. the "Shape" popup takes 1 - 2 seconds. Switching back to windows, combo pops up immediately.

arisona commented 2 months ago

To further narrow this a bit down:

Issue is reproducible on current dev (with metal instead of vk)
The lag seems only to occur as long as one doesn't move the mouse pointer out of the UI element, e.g. as soon as I leave the combo popup down box, the combo appears immediately. This seems to point at some minor mouse handling, or ui enter/exit issue.

combo_stuck

arisona commented 2 months ago

Actually looks very similar to #81828 - the difference I notice is that in the issue here you need to leave the combo box button for the combo to open, while in #81828 it's enough to move the mouse to open the context menu.

godotengine / godot