SVG does not render correctly in master as of PR #96167 (works in 4.3 stable)

godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine

https://godotengine.org

MIT License

91.48k stars 21.26k forks source link

SVG does not render correctly in master as of PR #96167 (works in 4.3 stable) #96262

Closed aaronfranke closed 2 months ago

aaronfranke commented 3 months ago

Tested versions

Reproducible in 4.4-dev commit ce8a837aab2568f9cdc41b4b410c478b0cd711fc (latest master as of writing)
Reproducible in 4.4-dev commit 1e41bf6a085
Reproducible in 4.4-dev commit bd04f687f0a
Reproducible in 4.4-dev commit a2f097d6035
Reproducible in 4.4-dev commit fe024443e36 PR #96167
Works fine in 4.4-dev commit b4eacfe0cec
Works fine in 4.4-dev commit 1ead46e78250b6b6a040f362ce48b7b1b93b7f65
Works fine in 4.4-dev commit 8ae2c3a0006
Works fine in 4.4-dev commit 08ffa5d89e4
Works fine in 4.3-stable

System information

macOS 14.6.1 arm64

Issue description

As of PR #96167, this SVG does not render correctly. There is a defect on the left of the image.

Incorrect image:

Correct image:

Steps to reproduce

Open the below SVG in the latest Godot master branch.

Minimal reproduction project (MRP)

Here is the SVG: icon

akien-mga commented 3 months ago

Confirmed. On the other hand I don't reproduce it on https://thorvg.github.io/thorvg.viewer/ which also claims to use 0.14.7, so there might be an issue with how we're using ThorVG.

I tested intermediate ThorVG releases between 0.14.2 (our previous version) and 0.14.7, and it appears that the regression was introduced in ~0.14.6~ 0.14.5.

Edit: I was in a hurry yesterday and mistested, the regression actually seems to have happened in 0.14.5. Also tested the new 0.14.8 which doesn't fix it.

I'll open an upstream bug report later today, but CC @mgrudzinska @hermett @capnm FYI.

akien-mga commented 3 months ago

I bisected the regression in thorvg to https://github.com/thorvg/thorvg/commit/fdc45edf32820b7e0979ed7f8a48a14d2adc8103 cc @mgrudzinska.

mgrudzinska commented 3 months ago

I'm on it, reproduced

capnm commented 2 months ago

CC @akien-mga Note++: The fundamental issue is still a work in progress...

https://github.com/thorvg/thorvg/pull/2711

https://github.com/godotengine/godot/commit/a6ab039f2b9e2d524b45186586cc880134fbee98

SVG: err

akien-mga commented 2 months ago

Yeah that's why I finally opted for reverting the Bézier precision change (which was motivated by Lottie which we don't use yet), restoring the pre-regression behavior. We can wait for ThorVG to find a good solution and then confirm it works in Godot.

Edit: to be clear, the SVG you shared should also be broken in earlier versions of Godot/ThorVG, right? If it's not a regression I don't think we need to track it here, just an upstream bug report is enough.

capnm commented 2 months ago

Edit: to be clear, the SVG you shared should also be broken in earlier versions of Godot/ThorVG, right? If it's not a regression I don't think we need to track it here, just an upstream bug report is enough.

I have now tested some older stable versions; it renders correctly (-- wrong angle) in 4.1.4 but is broken in v4.2.2, along with everything that follows. As you mentioned, it's already a known issue, and I agree. You could, I suppose, produce a lot of such floating-point precision-related SVGs...

editor_screenshot_2024-09-07T120003