search

godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
91.16k stars 21.19k forks source link

PBD renaming functionality assumes file is present when it shouldn't #96350

Closed ryevdokimov closed 2 months ago

ryevdokimov commented 2 months ago

Tested versions

Since: https://github.com/godotengine/godot/commit/e73f40e26067cf265e311bbb895b80853574cd93

System information

N/A

Issue description

In short, https://github.com/godotengine/godot/pull/87117 makes the assumption mentioned in the title resulting in error like this, which is now possible after this PR https://github.com/godotengine/godot/pull/93972: image

See comments here for details: https://github.com/godotengine/godot/pull/93972#issuecomment-2321833260

image

Steps to reproduce

Build: https://github.com/godotengine/godot/commit/f0ee0bdd376c7d32adb83754e4ae5899dba37f91 Add a plugin like Godot-Jolt that has an entry for PBD in the header (may have to build this for 4.4) Make sure .godot folder is deleted Open the project

Minimal reproduction project (MRP)

N/A

ghost commented 2 months ago

Having the same issue in 4.3 stable. Screenshot 2024-08-30 141400

tried reinstalling Jolt but no luck. Also tried renaming the dll to pdb for kicks and that just produced more errors.

mihe commented 2 months ago

If the errors bother you then you can (until this is fixed) just download the debug symbols for Godot Jolt here and extract them alongside the DLLs.

ghost commented 2 months ago

If the errors bother you then you can (until this is fixed) just download the debug symbols for Godot Jolt here and extract them alongside the DLLs.

It does bother me a bit, so I'll go ahead and do this. Thank you!