dmlary
commented
2 months ago Update
Everything below is wrong; I forgot I went up one frame before printing the Node3D transform.
The problem here is the heirarchy is:
- Node3D with transform
|- MeshInstance3D without transformMeshLibraryEditor::_import_scene_parse_node() only exports MeshInstance3Ds and doesn't take into account any parent transform.
Lies below this line
What's interesting here is that in MeshLibraryEditor::_import_scene_parse_node() if you cast p_node to Node3D, get_transform() returns the correct transform. But in the code the node is first cast to MeshInstance3D, and get_transform() returns the wrong value for the transform (the default, no transform).
Is this just because Node3D and MeshInstance3D are storing their transform in different places?
frame #0: 0x0000000101ccc740 godot.macos.editor.arm64`MeshLibraryEditor::_import_scene_parse_node(p_library=Ref<MeshLibrary> @ 0x000000016fdfbbc0, p_mesh_instances=0x000000016fdfbd50, p_node=<unavailable>, p_merge=<unavailable>, p_apply_xforms=true) at mesh_library_editor_plugin.cpp:161:45 [opt]
158
159 Transform3D item_mesh_transform;
160 if (p_apply_xforms) {
-> 161 item_mesh_transform = mesh_instance_node->get_transform();
162 }
163 p_library->set_item_mesh_transform(item_id, item_mesh_transform);
164
(lldb) p ((Node3D*)p_node)->get_transform()
(Transform3D) {
basis = {
rows = {
[0] = {
= {
= (x = 1, y = 0, z = 0)
coord = ([0] = 1, [1] = 0, [2] = 0)
}
}
[1] = {
= {
= (x = 0, y = 1, z = 0)
coord = ([0] = 0, [1] = 1, [2] = 0)
}
}
[2] = {
= {
= (x = 0, y = 0, z = 1)
coord = ([0] = 0, [1] = 0, [2] = 1)
}
}
}
}
origin = {
= {
= (x = 0, y = 1, z = 0)
coord = ([0] = 0, [1] = 1, [2] = 0) // <--- Correct origin: (0, 1, 0)
}
}
}
(lldb) n
Process 88630 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = step over
frame #0: 0x0000000101ccc760 godot.macos.editor.arm64`MeshLibraryEditor::_import_scene_parse_node(p_library=Ref<MeshLibrary> @ 0x000000016fdfbbc0, p_mesh_instances=0x000000016fdfbd50, p_node=<unavailable>, p_merge=<unavailable>, p_apply_xforms=true) at mesh_library_editor_plugin.cpp:163:2 [opt]
160 if (p_apply_xforms) {
161 item_mesh_transform = mesh_instance_node->get_transform();
162 }
-> 163 p_library->set_item_mesh_transform(item_id, item_mesh_transform);
164
165 Vector<MeshLibrary::ShapeData> collisions;
166 for (int i = 0; i < mesh_instance_node->get_child_count(); i++) {
Target 0: (godot.macos.editor.arm64) stopped.
(lldb) frame v item_mesh_transform
(Transform3D) item_mesh_transform = {
basis = {
rows = {
[0] = {
= {
= (x = 1, y = 0, z = 0)
coord = ([0] = 1, [1] = 0, [2] = 0)
}
}
[1] = {
= {
= (x = 0, y = 1, z = 0)
coord = ([0] = 0, [1] = 1, [2] = 0)
}
}
[2] = {
= {
= (x = 0, y = 0, z = 1)
coord = ([0] = 0, [1] = 0, [2] = 1)
}
}
}
}
origin = {
= {
= (x = 0, y = 0, z = 0)
coord = ([0] = 0, [1] = 0, [2] = 0) // <--- Wrong origin (0, 0, 0)
}
}
}
BlackShift
Tested versions
System information
Godot v4.3.stable - macOS 14.6.1 - Vulkan (Forward+) - integrated Apple M3 Max - Apple M3 Max (16 Threads)
Issue description
When using Scene -> Export As -> MeshLibrary with
Apply MeshInstance Transformsenabled, the transform to Node3Ds that are imported from a GLTF are not added to the MeshLibrary.Due to the explicit phrasing of "
MeshInstanceTransforms" I believe this is expected behaviour, but it's unexpected behavior from a user perspective. Tilesets frequently come in GLTF format, and it is very confusing to enable "Apply [...] Transform", but not have it applied to the exported meshes.I can understand if this is an immediate close bug, but I was unable to find any documentation of this limitation. Developers should be aware that if they PoC with MeshInstances, switching to GLTF assets later will not work if any transform is needed.
The only workaround I've found is to manually update the MeshLibrary in the editor for the transform.
Steps to reproduce
Demo:
(Added grass tile from kaykit midevil hexagon pack, and translated it up 1.0)
(Export with "Apply MeshInstance Transforms" enabled)
(Editing the Mesh in the MeshLibrary, the Mesh Transform has a y offset = 0; it should be 1.0)
Minimal reproduction project (MRP)
mesh-library-export-apply-transform.zip