godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
89.14k stars 20.21k forks source link

"Using present mode: Enabled" spam #96739

Open Withaust opened 1 week ago

Withaust commented 1 week ago

Tested versions

4.3 stable

System information

Windows 10 Godot 4.3 stable Vulkan

Issue description

Currently, every single time when you open another subwindow stuff like these tabs for example: image engine would print Using present mode: XXX. While actively working on the project your entire console could easily be filled with these messages: image

Steps to reproduce

^^^

Minimal reproduction project (MRP)

...

AThousandShips commented 1 week ago

Comes from this line: https://github.com/godotengine/godot/blob/d0dc3896ad6fe039e4ad0607d901c81197cb3a3b/drivers/vulkan/rendering_device_driver_vulkan.cpp#L2850

From:

CC @DarioSamo

DarioSamo commented 1 week ago

Verbose is pretty much meant to print information excessively for debugging purposes and this is because every single pop-up creates a swap chain for presentation and therefore prints which presentation mode the swap chain is using. I'm not entirely sure what behavior is preferred here.

Withaust commented 1 week ago

This really boils down to the fact that some of the verbose only logging stuff was never supposed to be verbose only (for example, orphan string name printing), and so if you are using something like GDExtension for your game, you are essentially forced into a verbose printing mode so you could catch some of the issues that the engine has. I see what you mean by this, but you also have to understand the issue that I have at hand as well, and why I am voicing concerns about this spam in verbose.