search

godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
89.54k stars 20.27k forks source link

`interface/editor/editor_screen` setting has no effect once window position is remembered #97051

Open KoBeWi opened 1 week ago

KoBeWi commented 1 week ago

Tested versions

4.4 dev2

System information

Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; 31.0.15.4633) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)

Issue description

There is interface/editor/editor_screen editor setting, which defines where the editor should appear at startup. After #76085, the editor will use the last window position (including screen), making the setting effectively useless. It has effect only when a project is opened for the first time.

Maybe we should just remove this setting now.

Steps to reproduce

  1. Change interface/editor/editor_screen to Screen 1
  2. Restart the editor while it is on screen 2
  3. It starts on screen 2

Minimal reproduction project (MRP)

N/A

akien-mga commented 1 week ago

We can either remove the setting, or change it to default to "Auto" that would be remembering the last position, and the other options should be treated as overrides.

bits-by-brandon commented 5 days ago

I like the idea of an "Auto" setting. Perhaps we can merge in the separate interface/editor/remember_window_size_and_position setting into this "Auto" option? Also some alternatives names for "Auto"

bits-by-brandon commented 5 days ago

I have a really rough PR of what this might look like. https://github.com/godotengine/godot/pull/97333 I'm a total C++ beginner though, so it's not entirely functional yet 😅