GPUParticles3D inherit velocity is broken - Githubissues

godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine

https://godotengine.org

MIT License

89.54k stars 20.27k forks source link

GPUParticles3D inherit velocity is broken #97160

Open huwpascoe opened 1 week ago

huwpascoe commented 1 week ago

Tested versions

4.3

System information

Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 960 (NVIDIA; 32.0.15.6081) - Intel(R) Core(TM) i5-6600K CPU @ 3.50GHz (4 Threads)

Issue description

inherit_velocity_ratio doesn't work as expected. Particles seem to emit ahead of where they're supposed to and this gap increases the higher the velocity.

The particle effect is placed at the back of the rocket, yet at this velocity they're being emitted near the front!

Steps to reproduce

Set inherit_velocity_ratio to greater than zero.

Minimal reproduction project (MRP)

particles_velocity_ratio.zip

KingTheFifth commented 3 days ago

Hiya! I am planning to look into this, just to give people a heads up

Calinou commented 3 days ago

Related to https://github.com/godotengine/godot/issues/87662.

Can you reproduce this in master? https://github.com/godotengine/godot/pull/93837 was merged there but hasn't been cherry-picked to 4.3.x yet.

huwpascoe commented 3 days ago

Improved! It works provided:

fixed_fps = 60 (matching physics tick)
interpolate = false
fract_delta = false

So question is, does this resolve the issue?

huwpascoe commented 15 hours ago

Confirmed in rendering meeting that no, the issue is not technically resolved. It should work for all the settings. Please go ahead @KingTheFifth

KingTheFifth commented 12 hours ago

Ok, thanks for confirming! I will begin working on it now