godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
91.35k stars 21.25k forks source link

Editor inspector issue - filename not updating when resource filename changed. #97456

Open sDIMMaX opened 2 months ago

sDIMMaX commented 2 months ago

Tested versions

Godot 4*

System information

Windows

Issue description

If rename resource file (tres, res), - this changes not updated name this resource in inspector. image image i rename file to BronzeSword, but in inspector still old name - Sword.tres Not critical issue, just QOL, but i make mistake based on wrong name :(

Steps to reproduce

Make resource, save to file, open in inspector, rename resource in file explorer, check name in inspector.

Minimal reproduction project (MRP)

-

am4sten commented 2 months ago

Hi @sDIMMaX so after doing your steps to reproduce, here's what I found :

I tried to reproduce it on 4.3-stable and it's a fine behaviour imo

sDIMMaX commented 1 month ago

@am4sten But if this script, and you change script name image you see new name image in inspector - old image

i think - missing update notification to inspector

sDIMMaX commented 1 month ago

https://github.com/godotengine/godot/blob/f7c567e2f56d6e63f4749387a67e5ea4903c4696/editor/editor_file_system.cpp#L912

connection inspector to this signal :)

or, near this place https://github.com/godotengine/godot/blob/f7c567e2f56d6e63f4749387a67e5ea4903c4696/editor/filesystem_dock.cpp#L1891

node_editor - connected