search

godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
91.1k stars 21.18k forks source link

MSVC fails to build and detect compilers for vs preview after #91069 #97619

Closed HKunogi closed 1 month ago

HKunogi commented 1 month ago

Tested versions

After this commit it fails to compile while using vs studio preview, the change on methods.py should take into account for preview versions by using the '-prerelease' flag on the command, and also take into account the return of the 'Preview' keyword on the result to properly parse the returned value.

System information

Windows 11

Issue description

Cannot build due to failure on detecting compiler when using vs studio preview, it used to work prior to the specified commit.

Steps to reproduce

Simply install vs studio preview (without any other versions installed) and try to build it using the scons script

Minimal reproduction project (MRP)

Build issue, so theres no MRP

akien-mga commented 1 month ago

Thanks for the report. It's a duplicate of #97614 so I'll consolidate it there. A fix will be merged shortly.

akien-mga commented 1 month ago

I misunderstood, this isn't a duplicate but specific to VS Preview.

HKunogi commented 1 month ago

@akien-mga @Repiteo It stills shows the issue due to the int parsing of the script, given the return string from vswhere when having preview versions differing from the normal ones. image in this case the sem_ver[2] contains "0 Preview 2.1".