godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
90.11k stars 21.16k forks source link

Debug CanvasItem Redraw is not available #98005

Open Rindbee opened 4 days ago

Rindbee commented 4 days ago

Tested versions

a657ea42f1e656695f502a0e5f50ea9e0e041c3e

System information

Godot v4.4.dev (842f98239) - Linux Mint 22 (Wilma) on X11 - X11 display driver, Multi-window, 1 monitor - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1050 Ti (nvidia; 535.183.01) - Intel(R) Core(TM) i5-7300HQ CPU @ 2.50GHz (4 threads)

Issue description

Debug CanvasItem Redraw is unavailable since #92797.

Steps to reproduce

Run the editor from the command line with the --debug-canvas-item-redraw option.

Or enable Debug -> Debug CanvasItem Redraw in the editor menu first, then run the scene.

Minimal reproduction project (MRP)

N/A

Calinou commented 3 days ago

cc @stuartcarnie

stuartcarnie commented 2 days ago

I ported the GLES3 code, and see that it isn't supported there either, which is why it didn't come across. I'll take a look to see what is required to re-introduce it to batching.

stuartcarnie commented 2 days ago

Re-implemented debug-draw support for batching. I believe this is what it should look like (@Calinou / @clayjohn):

CleanShot 2024-10-11 at 06 51 47

clayjohn commented 2 days ago

@stuartcarnie that's right!

stuartcarnie commented 14 hours ago

Will be fixed by #97340