SCons: slight refactor of module logic

godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine

https://godotengine.org

MIT License

91.38k stars 21.26k forks source link

SCons: slight refactor of module logic #99476

Open dustdfg opened 5 days ago

dustdfg commented 5 days ago

I saw that awful function which looks at version.py file and decided to rewrite it. This PR includes it and all other artifacts which I discovered during looking at module logic

There is also bugfix that if custom_modules pointed exactly at engine directory it included modules twice

DISCLAIMER: tightens us with SCons even more and relies on internals though it is not the first time these concrete internals are used

dustdfg commented 5 days ago

Yeah, I know that at the start of the file there is another logic for determining project root folder used in. The same is used in scu_builders.py but I don't want to unwind that net of cross-linking issues. Next time...

dustdfg commented 1 day ago

I am not going to do anything to update this PR. But it is not bad in IMO so I am not closing it... Over time some merge conflicts can occur... There are people with "write access" so if you need it you can correct it. I am abandoning this PR... If you want close it