godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
91.3k stars 21.24k forks source link

Toast and spam, when moving mouse out from 2d editor view trigger toast warning #99478

Open Giganzo opened 1 day ago

Giganzo commented 1 day ago

Tested versions

v4.4.dev.custom_build [9e6098432]

System information

Fedora Linux 40 (KDE Plasma) on Wayland - X11 display driver, Multi-window

Issue description

If you have selected control inside a container and move mouse out from the 2d editor to other parts of the editor. It will spam you with toast warnings. Trigger even more if you resize a dock.

https://github.com/user-attachments/assets/5d73816a-da73-4090-a6d1-c079d958dcf8

Steps to reproduce

Have a control node container with a child node Select child node Move mouse out from 2d editor or resize a dock

Minimal reproduction project (MRP)

toast_and_spam.zip

Giganzo commented 1 day ago

Would it be correct to remove true from this line (3615)?

if (!_is_node_movable(ci, true)) {

https://github.com/godotengine/godot/blame/9e6098432aac35bae42c9089a29ba2a80320d823/editor/plugins/canvas_item_editor_plugin.cpp#L3613-L3618