godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
91.3k stars 21.24k forks source link

Improve appearance of external links in built-in docs #99480

Open Mickeon opened 1 day ago

Mickeon commented 1 day ago

Closes https://github.com/godotengine/godot-proposals/issues/9369

This PR makes the external links in the built-in class reference:

I'm unconvinced on the actual color, though. See also a RocketChat thread. The gist of it is that, I feel like the excessive accent colour brings too much attention to external links, and the icon exists too. Links to the built-in class reference are more important in the editor and should be more notable, as well.

Normal Link Color Saturated Link Color
thumb-Clipboard - November 20, 2024 8_08 PM thumb-Clipboard - November 20, 2024 8_13 PM
Clipboard - November 20, 2024 8_08 PM Clipboard - November 20, 2024 8_14 PM

It's also currently not possible to hide the hint tag's underline individually. Hence the dotted underline on these links.

tetrapod00 commented 1 day ago

I think the bikeshed should be normal link colored.

Mickeon commented 1 day ago

Updated the PR to also reduce code duplication.