Bottom panel: Shader Editor keeps popping up over Animation tab

godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine

https://godotengine.org

MIT License

91.52k stars 21.26k forks source link

Bottom panel: Shader Editor keeps popping up over Animation tab #99772

Open vvye opened 4 days ago

vvye commented 4 days ago

Tested versions

Reproducible in 4.4dev5

System information

Godot v4.4.dev5 - Windows 10.0.19045 - Single-window, 1 monitor - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3070 (NVIDIA; 32.0.15.6094) - AMD Ryzen 7 5800X 8-Core Processor (16 threads)

Issue description

The UX of the bottom panel could greatly benefit from improvement. To keep this report contained to a single issue, here's something I've just run into:

when I want to edit an animation frame, I select the Sprite2D node to edit the keyframe - but then the animation panel switches over to the shader panel, so I have to switch back again before I can edit the keyframes.

https://github.com/user-attachments/assets/532f025d-314b-4e50-996f-60f99939654f

Steps to reproduce

make a Scene with both a Sprite2D, and an AnimationPlayer operating on that Sprite2D.
add a Shader to the Sprite2D.
create an animation in the AnimationPlayer.
with the Animation panel open, try to select the sprite2D.
contrary to what you'd expect, when you select the Sprite2D, the Shader Editor panel pops up, requiring you to switch to the Animation panel again before you can actually edit the keyframes.

(this seems to only happen after reopening the project?)

Minimal reproduction project (MRP)

mrp.zip

tetrapod00 commented 4 days ago

This very well might be a bug, but in the meantime you can use the pin (📌) icon to keep one of the bottom panel tabs open. It was recently added in https://github.com/godotengine/godot/pull/98074. If the bottom panel tabs are switching even when pinned open, this is definitely a bug.

tetrapod00 commented 4 days ago

I can't reproduce the behavior shown in your video, with the uploaded MRP, in Godot 4.4.dev5, on Windows 10. I tried restarting the project before attempting to replicate the steps in your video:

Open shader.
Select AnimationPlayer node.
In AnimationPlayer, select a frame.
Click on Sprite2D (in the Animation bottom panel).

Then I tried restarting again, repeating the steps, and still can't replicate.

There might be other editor or project settings involved in the behavior you saw. Or perhaps the editor bug is only triggered by a specific state that was only reached in your project, but not the MRP. Can you check again to see if you can replicate the behavior with only the MRP you uploaded, and if so, record a video of the steps?

Also, if you can reproduce the bug in 4.4dev5, can you also check the MRP in 4.3 and see if the bug is still there?

Thanks for reporting and thanks in advance for testing further.

matheusmdx commented 3 days ago

I tested this issue and actually there's an extra step that needs to be done for reproduce this bug:

Make a scene with both a Sprite2D and an AnimationPlayer operating on that Sprite2D.
Add a shader to the Sprite2D.
Create an animation in the AnimationPlayer.
Unfold the Sprite2D material property and unfold the shader property too (the missing step)
With the animation panel open, select the Sprite2D.
Contrary to what you'd expect, when you select the Sprite2D, the shader editor panel pops up, requiring you to switch to the animation panel again before you can actually edit the keyframes.

https://github.com/user-attachments/assets/db320b93-9b77-44cf-ae36-301d0d28ef40

Also, this is a regression from #95149, @KoBeWi

vvye commented 3 days ago

Thanks @matheusmdx for narrowing it down and @tetrapod00 for reminding me of the pin feature! Good to know it's an actual issue, and that I can work around it for the time being.