godotengine / tps-demo

Godot Third Person Shooter with high quality assets and lighting
Other
1.01k stars 180 forks source link

Latest godot engine can't open tps-demo 4.0-dev branch #107

Closed T-rvw closed 1 year ago

T-rvw commented 3 years ago

I would like to experience godot vulkan version so I downloaded tps-demo in 4.0-dev branch and built a godot engine in master branch. But the editor crashed during importing scene resources.

Any suggestions? I know that is an unstable engine version. I just wanted to get a nice demo to learn about godot vulkan rendering.

aaronfranke commented 3 years ago

The demo hasn't been ported yet. The 4.0-dev branch is currently identical to the master of this repo (designed for Godot 3.x).

T-rvw commented 3 years ago

@aaronfranke Thanks for your quick reply. Do you have any recommended samples for Godot 4.x which uses Vulkan as rendering backend?

aaronfranke commented 3 years ago

@T-rvw https://github.com/Calinou/godot-reflection

There aren't many currently. We should have more things ported in the future, but first we want to improve the automatic conversion tools so that the work can be automated. If you are looking to test rendering, another option is to copy the 3D model files from the TPS demo into an empty Godot 4 project.

T-rvw commented 3 years ago

Status update: Latest godot master version has some break changes on scene format so that many scenes got error : "Scene file '%s' appears to be invalid/corrupt.". See https://github.com/Calinou/godot-reflection/issues/5.

Anyway, it is closer to know there are valid samples based on godot 4.0. I will try to have a look at changes on scene format and know if it is possible to fix them.

qarmin commented 2 years ago

When using https://github.com/godotengine/godot/pull/51950, project opened before in editor mostly fine, but showed some errors(not sure if they are related to Godot, converter or tps-demo). For now it crashes like in #54515, so I can't test it more. Maybe it will be possible to change code in Godot 3 branch, to be able to convert project easily to newer version.

Now I see only this error

    1 | shader_type spatial;
E   2-> render_mode blend_mix,depth_draw_alpha_prepass,cull_back,diffuse_burley,specular_schlick_ggx;
    3 | uniform vec4 albedo : hint_color;
    4 | uniform sampler2D texture_albedo : hint_albedo;
    5 | uniform float point_size : hint_range(0,128);
    6 | uniform float emission_energy = 2.0;
    7 | 
    8 | 
    9 | void fragment() {
   10 |     vec2 base_uv = UV;
   11 |     vec4 albedo_tex = texture(texture_albedo,base_uv);
   12 |     albedo_tex *= COLOR;
   13 |     ALBEDO = albedo.rgb * albedo_tex.rgb;
   14 |     EMISSION = ALBEDO * emission_energy;
   15 | }
   16 | 
ERROR: Invalid render mode: 'depth_draw_alpha_prepass'
   at: (null) (:2)
ERROR: Shader compilation failed.
   at: set_code (servers/rendering/renderer_rd/forward_clustered/scene_shader_forward_clustered.cpp:136)
fire commented 1 year ago

I recently tested this and the godot 4 branch works on godot 4.0 latest.