godotengine / tps-demo

Godot Third Person Shooter with high quality assets and lighting
Other
953 stars 166 forks source link

Red Robots miss the player at longer ranges #129

Open aidan-j-rhoden opened 1 year ago

aidan-j-rhoden commented 1 year ago

OS/device including version: Linux

Issue description: When the red robots fire at the player, the beam is consistently off by a slight angle. At longer ranges, this is enough to miss the player completely. The beam should be right on the player, instead of slightly to the left.

Screenshots of issue: Screenshot

Calinou commented 1 year ago

I can reproduce this on 3.5 + https://github.com/godotengine/tps-demo/commit/c1c4cc2deed677f7abcb558713aaf7ee7b4be2ab.

The beam's rotation seems to be parented to the enemy's cannon, so fixing this will require redoing entirely how the enemy actually aims the projectile (even if it ends up misaligned from the cannon).

aidan-j-rhoden commented 1 year ago

That should be fine in maintaining VFX quality, because to need that fix you would have to be far enough from the robot, so it shouldn't be noticeable from there, right?

Calinou commented 1 year ago

That should be fine in maintaining VFX quality, because to need that fix you would have to be far enough from the robot, so it shouldn't be noticeable from there, right?

I don't have a problem with that, but reworking the aiming logic is probably nontrivial. Feel free to look into it, but I don't have much time to work on the demo right now.

aidan-j-rhoden commented 1 year ago

Will do, thanks!