godotengine / tps-demo

Godot Third Person Shooter with high quality assets and lighting
Other
955 stars 166 forks source link

Occluder shape placement is too aggressive #148

Closed norrath-hero-cn closed 1 year ago

norrath-hero-cn commented 1 year ago

Godot version

Godot Engine v3.5.1.stable.official.6fed1ffa3 - https://godotengine.org

System information

Windows 10 x64, OpenGL ES 3.0 Renderer: NVIDIA GeForce GTX 960/PCIe/SSE2

Issue description

It seems 3.5.x complete unusable for 3d because of this flaw!

https://user-images.githubusercontent.com/73905273/208269834-9a760f88-2808-4816-a83e-ced38879f4f0.mp4

https://user-images.githubusercontent.com/73905273/208269842-8f0a8c11-1ddd-4978-83a6-51e3133a2f13.mp4

https://user-images.githubusercontent.com/73905273/208269876-66b0c231-1469-4871-8d6f-6f6662fd6a6b.mp4

https://user-images.githubusercontent.com/73905273/208269881-7d492a2a-1b0f-4e83-9eb3-7c2edfdb1a26.mp4

Steps to reproduce

Just use tps-demo please, it can easily reproduce!

Minimal reproduction project

https://github.com/godotengine/tps-demo

Calinou commented 1 year ago

Just use godot-sponza please, it can easily reproduce!

The videos you've shown are from https://github.com/godotengine/tps-demo, not https://github.com/Calinou/godot-sponza.

PS: Remember that for GitHub video previews to work, you need to have a blank line before and after the video URL. I edited your post accordingly, but remember to do this in the future :slightly_smiling_face:

norrath-hero-cn commented 1 year ago

Sorry, I copy/paste the wrong url & name!

Calinou commented 1 year ago

This is not an engine bug – it's an issue specific to this demo. I can confirm this on 3.5.1.

This is a bug caused by occluder geometry placement being too aggressive. I forgot that you can get the camera all the way down to the floor, which breaks occlusion culling if the camera can get inside occluder shapes.