search

godotengine / tps-demo

Godot Third Person Shooter with high quality assets and lighting
Other
955 stars 166 forks source link

Recommendation to run the project converter #164

Closed RevoluPowered closed 1 year ago

RevoluPowered commented 1 year ago

Since the latest godot RC is out I recommend running the 3 to 4 project converter at least once on this as I have made a fix upstream for a node ownership issue which this repository has present.

It should resolve a crash I found when running the game.

RevoluPowered commented 1 year ago

https://github.com/godotengine/godot/pull/73725

clayjohn commented 1 year ago

We already have a 4.0 port mostly done, so its a bit late to run the converter again. In my local branch I went a ahead and did the renames manually. Will make a PR soon

RevoluPowered commented 1 year ago

nice!

Calinou commented 1 year ago

Fixed by https://github.com/godotengine/tps-demo/pull/166.