search

godotengine / webrtc-native

The official GDNative WebRTC implementation for non-html exports.
MIT License
210 stars 34 forks source link

Statically link libgcc and libstdc++ on linux #109

Closed Faless closed 1 year ago

Faless commented 1 year ago

More compatibility at the cost of bigger binaries.

Fixes #110

Faless commented 1 year ago

@goatchurchprime could you check if this solves #110 for you on NixOS? Artifact: https://github.com/godotengine/webrtc-native/suites/13952118382/artifacts/777450622

goatchurchprime commented 1 year ago

@goatchurchprime could you check if this solves #110 for you on NixOS? Artifact: https://github.com/godotengine/webrtc-native/suites/13952118382/artifacts/777450622

It does indeed work perfectly (though the artifact is zipped twice).

Just wondering, what's the reason this has to be hand-copied into its own directory like this, instead of being done through the easy-to-install asset library? For something that is connected to so many core node classes, it is quite unexpected that it has to be made to work in this kind of hacky way.

Faless commented 1 year ago

We have plans to distribute it via the asset library, I'll try to make it happen for the next release.

On Thu, Jun 29, 2023, 20:15 Julian Todd @.***> wrote:

@goatchurchprime https://github.com/goatchurchprime could you check if this solves #110 https://github.com/godotengine/webrtc-native/issues/110 for you on NixOS? Artifact: https://github.com/godotengine/webrtc-native/suites/13952118382/artifacts/777450622

It does indeed work perfectly (though the artifact is zipped twice).

Just wondering, what's the reason this has to be hand-copied into its own directory like this, instead of being done through the easy-to-install asset library? For something that is connected to so many core node classes, it is quite unexpected that it has to be made to work in this kind of hacky way.

— Reply to this email directly, view it on GitHub https://github.com/godotengine/webrtc-native/pull/109#issuecomment-1613588800, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAM4C3W3NXEENDDIT7MIBBTXNW7P5ANCNFSM6AAAAAAZYPCU2Q . You are receiving this because you authored the thread.Message ID: @.***>