search

godotengine / webrtc-native

The official GDNative WebRTC implementation for non-html exports.
MIT License
198 stars 27 forks source link

fix SCons on Osx Issue #59 #67

Closed mattkanwisher closed 1 year ago

mattkanwisher commented 1 year ago

It doesn't pull in the PATH variable so it can't find Cmake from Homebrew

mattkanwisher commented 1 year ago

more I dig into SCONs the more I agree with @akien-mga about detecting tools. Honestly linking scons with cmake looks like a not great choice of mixing tools. could bike shed for weeks on how to configure the system. If this doesn't break anything else, its probably not worth doing a ton of work on build scripts

My team is really looking to add some new features to this library, but just fixing builds on various platforms to get our feet wet

Faless commented 1 year ago

I worked on this yesterday, and opened #74, which takes the approach suggested by @akien-mga in https://github.com/godotengine/webrtc-native/pull/67#discussion_r1030682125 and is the same approach we use in Godot. I.e. we prepend the PATH and PKG_CONFIG_PATH (for the build godot toolchain) to the environment, without creating it with the full ENV=os.environ, and confirmed it works on mac with homebrew cmake in PATH but not linked to /usr/local/bin.

Windows is gonna require more work, there's a few path to sanitize, but most importantly getting the MSVC+nmake build going with openssl, so I would suggest people to use WSL to make builds for now.