search

godotengine / webrtc-native

The official GDNative WebRTC implementation for non-html exports.
MIT License
198 stars 27 forks source link

Release export crash #92

Closed Trey2k closed 1 year ago

Trey2k commented 1 year ago

Godot version

v4.0.2.stable

Plugin version

v1.0.0-rc1

System information

Arch linux: 6.3.2-arch1-1

Issue description

When exporting a game as release not debug it will crash when a connection is attempted: image

Steps to reproduce

Minimal reproduction project

https://github.com/godotengine/godot-demo-projects/tree/master/networking/webrtc_minimal

Trey2k commented 1 year ago

Windows releases also crash.

Faless commented 1 year ago

Thanks for reporting, I've confirmed the issue, this seems to have been fixed in upstream godot-cpp via https://github.com/godotengine/godot-cpp/pull/1053 .

I've opened #93 to update godot-cpp to 4.0-stable.

I'll prepare a new release shortly.

Trey2k commented 1 year ago

I am able to confirm the new build from actions works as expected in a release export. Thanks for the quick fix!

Faless commented 1 year ago

Closing as fixed via https://github.com/godotengine/webrtc-native/pull/93, a new stable release is available which includes the fix.