search

godwokenrises / godwoken-kicker

one line command to start godwoken-polyjuice chain.
19 stars 24 forks source link

Feat/posix compliant #311

Closed sleepyyj closed 2 years ago

sleepyyj commented 2 years ago

Linked to this issue. https://github.com/RetricSu/godwoken-kicker/issues/310

sleepyyj commented 2 years ago

There is one staled code:

https://github.com/RetricSu/godwoken-kicker/blob/daa5e2c38f851b7e2994b27c73440d32b99bbb0f/kicker#L123

@sleepyyj

fixed

sleepyyj commented 2 years ago

It would be nice if there was a test script that could be run locally

keroro520 commented 2 years ago

It would be nice if there was a test script that could be run locally

Usualy, simply ./kicker start is enough to test. However, kicker supports manual-build functional, which is internal use and CI use only. I agree that it would be nice if there was a test script that could be run locally, but it is very low priority :D