goebish / nrf24_multipro

nRF24L01 multi-protocol RC transmitter
GNU General Public License v3.0
472 stars 195 forks source link

some optimization perhaps #31

Closed silver13 closed 6 years ago

silver13 commented 6 years ago

https://github.com/goebish/nrf24_multipro/blob/869a6b4e7206353a8152595f86dd8af2e66a8dfa/nRF24_multipro/XN297_emu.ino#L140

sorry to open an issue, don't seem to know how to leave a comment lol

I think the line is equivalent to

    msg[i] = bit_reverse(msg[i]^xn297_scramble[i+xn297_addr_len]) ;
goebish commented 6 years ago

I think you're right, I'll change it once (if 😛 ) I implement crc in receive.

silver13 commented 6 years ago

cool, haven't tested it