Homeassistant MQTT autodiscover (missing entities)

goecharger / go-eCharger-API-v2

New API specification for V3 and V4 go-eCharger

95 stars 20 forks source link

Homeassistant MQTT autodiscover (missing entities) #241

Open mmick08 opened 2 months ago

mmick08 commented 2 months ago

Hi Guys,

First of all, thank you for integrating Homeassistant MQTT directly in your firmware. A great step underlining your dedication to open source.

I just wanted to point out the following topics:

Missing entities:

Even if the auto discover works very well several important entities to do home automation are missing. i.e. "Car Connected" (is the cable plugged in or not) "Configured phases" (how many phases are currently used) "phase switching" (possibility to choose between automatic, 1-phase, 3-phases)

Wrong entity details:

As for now the "total_energy_charged" cannot be used within the Energy dashboard as state_class: total_increasing is missing for the entity.

BR Manuel

CommanderRedYT commented 2 months ago

Hi Manuel, I took a look at your issue.

For the "Car Connected", there already exists the "Car State" in Homeassistant, so that should be covered. It should be 1:1 the Api-Key car.
For the phases, I will expose the Api-Key pha.
Phase switching will also be implemented.
Also, I added total_increasing to total_energy_charged.

I do not know yet when we release this, but I will write here again!

Thanks for your feedback :)

mmick08 commented 2 months ago

Hi,

Unfortunately, the 'car' variable is not properly exposed. The only available boolean is 'allowed to charge,' but its value is sometimes 'True' even when the car is not connected.

Thanks for the rest. 👌🏼

CommanderRedYT commented 2 months ago

Hi Manuel, I took a look at your issue.

For the "Car Connected", there already exists the "Car State" in Homeassistant, so that should be covered. It should be 1:1 the Api-Key car.
For the phases, I will expose the Api-Key pha.
Phase switching will also be implemented.
Also, I added total_increasing to total_energy_charged.

I do not know yet when we release this, but I will write here again!

Thanks for your feedback :)

mmick08 commented 2 months ago

Hi!

why posting the same message again ? :)

"Car" or Car State is NOT available. See Screenshot. Thats what i said.

Br Manuel

CommanderRedYT commented 2 months ago

Hm, my instance for some reason showed it despite the error in #244. After this is fixed, it should be visible.

mmick08 commented 2 months ago

Thank you 👍🏼

mmick08 commented 1 month ago

Thank you for the latest Beta. Now as you said "Car state" is available BUT its not the connected state at all! 🙈

Connected State should be a boolean either True or False not something like "Charging, Idle, WaitCar..."

Everything else like total_increasing for Total Energy and phase switching is now working 🎉. Thanks for that.