CrmLookupEntity.equals(Object) issues

[rgoldberg]

In CrmLookupEntity.equals(Object), if o == null, you get a NullPointerException.

If ! (o instanceof CrmLookupEntity), you get a GroovyCastException

Existing code:

boolean equals(o) {
    if (this.is(o)) return true
    //if (getClass() != o.class) return false
    // TODO How can we handle Hibernate proxies here without importing org.hibernate?
    // grails.plugins.crm.order.CrmOrderStatus_$$_javassist_7
    // grails.plugins.crm.order.CrmOrderStatus

    CrmLookupEntity that = (CrmLookupEntity) o

    if (this.id != that.id) return false
    if (this.orderIndex != that.orderIndex) return false
    if (this.name != that.name) return false
    if (this.param != that.param) return false

    return true
}

The following commented line should be replaced:

    //if (getClass() != o.class) return false

by something like:

    if (o == null || getClass() != o.class) return false

or:

    if (o == null || ! getClass().isAssignableFrom(o.class)) return false

A NullPointerException will also be thrown by CrmContactAddress.equals(Object), so you should check all of the equals(Object) methods in all of the crm classes.

If you want, the following article is useful for implementing robust equals(Object) methods:

http://www.artima.com/lejava/articles/equality.html

[rgoldberg]

Have you had a chance to look into this issue?

[goeh]

No, not yet. I'm sorry but I'm too overloaded with client work at the moment. But I appreciate your findings in this area. I will take a look at it, but I cannot promise any dates.