search

goelhardik / ignore

.gitignore based parser implemented in C# according to the .gitignore spec 2.29.2.
MIT License
50 stars 5 forks source link

Escape dots in the beginning #20

Closed goelhardik closed 3 years ago

goelhardik commented 3 years ago

*.mm.* -> .*\.mm\.[^/]*(/.*)?$

pull-request-quantifier-deprecated[bot] commented 3 years ago

Pull Request Quantified (Extra Small)

This PR has 12 quantified lines of changes. In general, a change size of 50 to 200 lines is ideal for the best PR experience!

Quantification details

``` Label : Extra Small Size : +12 -0 Percentile : 4.8% Total files changed: 4 Change summary by file extension: .cs : +12 -0 ``` > Change counts above are quantified counts, based on the [PullRequestQuantifier customizations](https://github.com/microsoft/PullRequestQuantifier/blob/main/docs/prquantifier-yaml.md).

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a balance between between PR complexity and PR review overhead. PRs within the optimal size (typical small, or medium sized PRs) mean: - Fast and predictable releases to production: - Optimal size changes are more likely to be reviewed faster with fewer iterations. - Similarity in low PR complexity drives similar review times. - Review quality is likely higher as complexity is lower: - Bugs are more likely to be detected. - Code inconsistencies are more likely to be detetcted. - Knowledge sharing is improved within the participants: - Small portions can be assimilated better. - Better engineering practices are exercised: - Solving big problems by dividing them in well contained, smaller problems. - Exercising separation of concerns within the code changes. #### What can I do to optimize my changes - Use the PullRequestQuantifier to quantify your PR accurately - Create a context profile for your repo using the [context generator](https://github.com/microsoft/PullRequestQuantifier/releases) - Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the `Excluded` section from your `prquantifier.yaml` context profile. - Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your `prquantifier.yaml` context profile. - Only use the labels that matter to you, [see context specification](./docs/prquantifier-yaml.md) to customize your `prquantifier.yaml` context profile. - Change your engineering behaviors - For PRs that fall outside of the desired spectrum, review the details and check if: - Your PR could be split in smaller, self-contained PRs instead - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR). #### How to interpret the change counts in git diff output - One line was added: `+1 -0` - One line was deleted: `+0 -1` - One line was modified: `+1 -1` (git diff doesn't know about modified, it will interpret that line like one addition plus one deletion) - Change percentiles: Change characteristics (addition, deletion, modification) of this PR in relation to all other PRs within the repository.

Was this comment helpful? :thumbsup:  :ok_hand:  :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.

codecov[bot] commented 3 years ago

Codecov Report

Merging #20 (e2622a3) into main (1617d5e) will increase coverage by 0.15%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   95.55%   95.71%   +0.15%     
==========================================
  Files           4        4              
  Lines         135      140       +5     
==========================================
+ Hits          129      134       +5     
  Misses          6        6
Impacted Files Coverage Δ
src/Ignore/IgnoreRule.cs 100.00% <100.00%> (ø)
src/Ignore/ReplacerStash.cs 98.43% <100.00%> (+0.10%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1617d5e...e2622a3. Read the comment docs.

jairbubbles commented 3 years ago

I was about to send a PR that fixes it... 🤦

goelhardik commented 3 years ago

I was about to send a PR that fixes it... 🤦

Lol sorry I saw you created an issue and I had some time. Let's assign issues next time so we know who's working on it.

jairbubbles commented 3 years ago

FYI I created a PR on git repository as I think there's a typo in the documentation => https://github.com/git/git/pull/972.

(The contribution process is very complicated on this repository 😣)

goelhardik commented 3 years ago

Oh nice.