search

goelhardik / ignore

.gitignore based parser implemented in C# according to the .gitignore spec 2.29.2.
MIT License
50 stars 5 forks source link

Strong Name Assembly #36

Closed TwentyFourMinutes closed 1 year ago

TwentyFourMinutes commented 1 year ago

We are building a library in which we are relying on this project. We would like to strong name the library, however this would require to all the dependencies to be strong named as well, which as already mentioned includes this one. It would be the most convenient way for us and it would be a nice benefit for everyone else relying on this project.

In essence to fix this create a .snk file and enter the following command in a Developer Command Prompt for VS:

sn -k ignore.snk

Move the file to the same location as the Directory.Build.props and add the following inside the Directory.Build.props file:

<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)/ignore.snk</AssemblyOriginatorKeyFile>
<SignAssembly>true</SignAssembly>

If you need any further assistance, or want me to create a PR for this feel free to tell me so. Any effort on your end is highly appreciated 😄

goelhardik commented 1 year ago

@TwentyFourMinutes Thanks for the instructions here. I have pushed a PR (#37) for this. Let me know if it looks good.