search

goenning / google-indexing-script

Script to get your site indexed on Google in less than 48 hours
https://seogets.com
MIT License
6.96k stars 483 forks source link

Moving from `mjs` to `ts` #28

Closed AntoineKM closed 8 months ago

AntoineKM commented 8 months ago

What did I change? I just switched from mjs to ts (commonjs), no more/no fewer features, all this to get all ts benefits.

Why did I change it? As a new contributor, it is difficult to directly understand how the code is working, using the shared functions and what should it return, etc. Also, I think that in the long term, it might be a good idea to have safe types for future contributions.

goenning commented 8 months ago

looks good, but was there any actual code/feature change @AntoineKM or is this just a migration to TS?

AntoineKM commented 8 months ago

looks good, but was there any actual code/feature change @AntoineKM or is this just a migration to TS?

Thanks, it's just a migration to TS, I'll do other pull requests with new features, once this one is merge 😁